Allow omitting empty collections via DefaultValuesHandling
#608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
premun
changed the title
DefaultValuesHandling.OmitDefaultsOrEmptyDefaultValuesHandling
|
@aaubry would it be possible to get this looked at? It would help my other project a lot to have this capability |
This was referenced May 12, 2021
premun
added a commit
to sharpliner/sharpliner
that referenced
this pull request
May 17, 2021
This is a temporary workaround before aaubry/YamlDotNet#608 gets merged. This makes the YAML not contain bunch of rows like this: ``` variables: [] ```
premun
added a commit
to sharpliner/sharpliner
that referenced
this pull request
May 17, 2021
**Makes the project use the pipeline defined using Sharpliner inside the `Sharpliner.CI` project!** Adds an AzDO task that will verify whether you have published and commited all changes into YAML files. (resolves #3) The many empty arrays in the YAML will be gone once we check in aaubry/YamlDotNet#608
I'm sorry, I wasn't able to look at this until today. I'm reviewing the PR now. |
aaubry
reviewed
May 30, 2021
YamlDotNet/Serialization/ObjectGraphVisitors/DefaultValuesObjectGraphVisitor.cs
Outdated
Show resolved
Hide resolved
YamlDotNet/Serialization/ObjectGraphVisitors/DefaultValuesObjectGraphVisitor.cs
Outdated
Show resolved
Hide resolved
YamlDotNet/Serialization/ObjectGraphVisitors/DefaultValuesObjectGraphVisitor.cs
Outdated
Show resolved
Hide resolved
|
Thanks and sorry about the slow response time. |
|
This feature has been released in version 11.2.0. |
|
Thanks @aaubry!! |
|
@tjstjsgt we have made these options into So you could set the policy to Or is there a problem? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Sometimes, you cannot cannot afford to null your enumerables but you don't want them in your YAML.
This default value handling policy allows to prevent serialization of empty arrays/lists/dictionaries into
Change
Added 2 new options:
DefaultValuesHandling.OmitDefaultsOrEmptyDefaultValuesHandling.OmitNullOrEmptywhich turns on omitting of empty collections.